Constructive recommendations: - add tests (I couldn't find a simple _test.go fil... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

yandrypozo on March 25, 2020 | parent | context | favorite | on: Show HN: Sorcia – Self-hosted web front end for Gi...

Constructive recommendations: - add tests (I couldn't find a simple _test.go file) - relative imports aren't recommended in Go (pkgs like "sorcia/model") - please rethink/avoid global (package) variables like middlewareDB (https://git.mysticmode.org/r/sorcia/tree/master/middleware/m...) - avoid adding logic in the init() functions - screenshots?

platinumrad on March 25, 2020 [–]

All of those seem fine aside from logic in init() functions. In particular, not sure how global variables in someone else's code impacts you.

Consider applying for YC's Fall 2026 batch! Applications are open till July 27.
Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact