I think the only thing non disclosure benefits is the company. I lived abroad for many years, and salary was freely discussed. I think doing so is great for an employee.